refactor(rust): Remove deprecated MutableBitmap.null_count method (#…

…16797)
pola-rs · Jun 7, 2024 · 1fc9a59 · 1fc9a59
1 parent fee68e3
commit 1fc9a59
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 12 deletions.
diff --git a/crates/polars-arrow/src/bitmap/mutable.rs b/crates/polars-arrow/src/bitmap/mutable.rs
@@ -255,12 +255,6 @@ impl MutableBitmap {
         self.length - self.unset_bits()
     }
 
-    /// Returns the number of unset bits on this [`MutableBitmap`].
-    #[deprecated(since = "0.13.0", note = "use `unset_bits` instead")]
-    pub fn null_count(&self) -> usize {
-        self.unset_bits()
-    }
-
     /// Returns the length of the [`MutableBitmap`].
     #[inline]
     pub fn len(&self) -> usize {

diff --git a/py-polars/polars/functions/lazy.py b/py-polars/polars/functions/lazy.py
@@ -1373,6 +1373,9 @@ def arctan2d(y: str | Expr, x: str | Expr) -> Expr:
     """
     Compute two argument arctan in degrees.
 
+    .. deprecated:: 1.0.0
+        Use `arctan2` followed by :meth:`Expr.degrees` instead.
+
     Returns the angle (in degrees) in the plane between the positive x-axis
     and the ray from the origin to (x,y).
 

diff --git a/py-polars/polars/lazyframe/frame.py b/py-polars/polars/lazyframe/frame.py
@@ -3966,7 +3966,7 @@ def join(
                 "Use of `how='outer'` should be replaced with `how='full'`.",
                 version="0.20.29",
             )
-        elif how == "outer_coalesce":
+        elif how == "outer_coalesce":  # type: ignore[comparison-overlap]
             coalesce = True
             how = "full"
             issue_deprecation_warning(

diff --git a/py-polars/polars/type_aliases.py b/py-polars/polars/type_aliases.py
@@ -139,7 +139,7 @@
 ClosedInterval: TypeAlias = Literal["left", "right", "both", "none"]  # ClosedWindow
 InterpolationMethod: TypeAlias = Literal["linear", "nearest"]
 JoinStrategy: TypeAlias = Literal[
-    "inner", "left", "full", "semi", "anti", "cross", "outer", "outer_coalesce"
+    "inner", "left", "full", "semi", "anti", "cross", "outer"
 ]  # JoinType
 RollingInterpolationMethod: TypeAlias = Literal[
     "nearest", "higher", "lower", "midpoint", "linear"

diff --git a/py-polars/src/conversion/mod.rs b/py-polars/src/conversion/mod.rs
@@ -748,10 +748,6 @@ impl<'py> FromPyObject<'py> for Wrap<JoinType> {
             "inner" => JoinType::Inner,
             "left" => JoinType::Left,
             "full" => JoinType::Full,
-            "outer_coalesce" => {
-                // TODO! deprecate
-                JoinType::Full
-            },
             "semi" => JoinType::Semi,
             "anti" => JoinType::Anti,
             #[cfg(feature = "cross_join")]