handle equality of categorical vs enum

pola-rs · Jan 28, 2024 · 373b7ee · 373b7ee
1 parent 91ddc6c
commit 373b7ee
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/crates/polars-core/src/datatypes/dtype.rs b/crates/polars-core/src/datatypes/dtype.rs
@@ -80,7 +80,6 @@ impl PartialEq for DataType {
         use DataType::*;
         {
             match (self, other) {
-                // Don't include rev maps in comparisons
                 #[cfg(feature = "dtype-categorical")]
                 (Categorical(_, _), Categorical(_, _)) | (Enum(_, _), Enum(_, _)) => true,
                 (Datetime(tu_l, tz_l), Datetime(tu_r, tz_r)) => tu_l == tu_r && tz_l == tz_r,

diff --git a/py-polars/tests/unit/datatypes/test_enum.py b/py-polars/tests/unit/datatypes/test_enum.py
@@ -404,7 +404,7 @@ def test_enum_creating_col_expr() -> None:
         },
         schema={
             "col1": pl.Enum(["a", "b", "c"]),
-            "col2": pl.String,
+            "col2": pl.Categorical(),
             "col3": pl.Enum(["g", "h", "i"]),
         },
     )