Skip to content

Commit

Permalink
feature flag
Browse files Browse the repository at this point in the history
  • Loading branch information
orlp committed Oct 23, 2024
1 parent ace8245 commit 90b45c6
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
1 change: 1 addition & 0 deletions crates/polars-lazy/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ dynamic_group_by = [
"temporal",
"polars-expr/dynamic_group_by",
"polars-mem-engine/dynamic_group_by",
"polars-stream/dynamic_group_by"
]
ewma = ["polars-plan/ewma"]
ewma_by = ["polars-plan/ewma_by"]
Expand Down
1 change: 1 addition & 0 deletions crates/polars-stream/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,4 @@ version_check = { workspace = true }
nightly = []
bitwise = ["polars-core/bitwise", "polars-plan/bitwise"]
merge_sorted = ["polars-plan/merge_sorted"]
dynamic_group_by = []
12 changes: 6 additions & 6 deletions crates/polars-stream/src/physical_plan/lower_ir.rs
Original file line number Diff line number Diff line change
Expand Up @@ -329,19 +329,19 @@ pub fn lower_ir(
maintain_order,
options,
} => {
if apply.is_some() {
if apply.is_some() || *maintain_order {
todo!()
}

#[cfg(feature = "dynamic_group_by")]
if options.dynamic.is_some() || options.rolling.is_some() {
todo!()
}

let key = keys.clone();
let mut aggs = aggs.clone();
let maintain_order = *maintain_order;
let options = options.clone();

if options.dynamic.is_some() || options.rolling.is_some() || maintain_order {
todo!()
}

polars_ensure!(!keys.is_empty(), ComputeError: "at least one key is required in a group_by operation");

// TODO: allow all aggregates.
Expand Down

0 comments on commit 90b45c6

Please sign in to comment.