Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust!): Rename Utf8 data type to String #13224

Merged
merged 36 commits into from
Dec 27, 2023
Merged

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Dec 23, 2023

This prepares a future update where the String datatype may have a different representation than the standard arrow Utf8 format.

This is just the Rust side. It also renames related functionality like Utf8Chunked, AnyValue::Utf8, etc.
Obviously, no functional changes.

The Arrow data types are not renamed. ArrowDataType::Utf8, Utf8Array, etc. all remain the same.

On the Python side, we will add String and keep Utf8 as an alias. I will do this in a separate PR as it is a bit more delicate to make sure the alias works correctly.

@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate internal An internal refactor or improvement rust Related to Rust Polars labels Dec 23, 2023
@stinodego stinodego marked this pull request as ready for review December 23, 2023 18:21
@stinodego stinodego marked this pull request as draft December 23, 2023 22:10
@ritchie46
Copy link
Member

This prepares a future update where the String datatype may have a different representation than the standard arrow Utf8 format.

It is unrelated though. ^^

@stinodego stinodego marked this pull request as ready for review December 25, 2023 20:11
@ritchie46 ritchie46 merged commit 0489783 into main Dec 27, 2023
28 checks passed
@ritchie46 ritchie46 deleted the utf8-to-string branch December 27, 2023 07:17
@c-peters c-peters added the accepted Ready for implementation label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation breaking rust Change that breaks backwards compatibility for the Rust crate internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants