fix(rust, python): allow list creation of decimals #13851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcrumiller
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
orlp
as code owners
github-actions
bot
added
fix
mcrumiller
commented
Jan 19, 2024
| list_capacity, | ||
| value_capacity, | ||
| inner_type_logical.clone(), | ||
| ))), |
There was a problem hiding this comment.
I would have simply expanded the match_dtype_to_logical_apply_macro but there is no Int128 dtype, so instead we have to directly supply the type here. Do we want to keep Int128 hidden or should we make a new dtype?
There was a problem hiding this comment.
It should still remain hidden. Maybe we opt for supporting it one day, but not now.
ritchie46
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13845.