-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(python): Make to_pandas()
work for Dataframe and Series with dtype Object
#13910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I left a bunch of small comments.
@stinodego ready for another round of review, if you have a moment. |
to_pandas()
work for Dataframe and Series with dtype Object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments. With that, this should be good to merge.
I am not too happy with splitting up the implementation up like this (different strategies for different columns, then merge them). The Object columns are not converted in parallel and I am not sure about the performance implications of inserting them one-by-one into a pandas dataframe (maybe this is free, not sure).
For now it seems warranted to correctly handle Object types. But I wonder what a more ideal solution would look like.
PS: Could you send me another message on Discord? I lost our previous conversation and I can't find you by your username.
d0c1393
to
e01fffa
Compare
e01fffa
to
2df6625
Compare
@stinodego back to you. |
Thank you @itamarst |
Fixes #13021