Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust, python): Allow dtype merge when inner dtype is enum #13938

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix(rust, python): Allow dtype merge when inner dtype is enum #13938

merged 1 commit into from
Jan 24, 2024

Conversation

mcrumiller
Copy link
Contributor

Resolves #13937.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 23, 2024
@mcrumiller mcrumiller changed the title fix(rust, python): Allow dtype merge of pl.List[pl.Enum] fix(rust, python): Allow dtype merge when inner dtype is enum Jan 23, 2024
ritchie46
ritchie46 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, thanks!

@ritchie46 ritchie46 merged commit b147350 into pola-rs:main Jan 24, 2024
24 checks passed
r-brink pushed a commit to r-brink/polars that referenced this pull request Jan 24, 2024
@mcrumiller @r-brink
fix(rust, python): Allow dtype merge when inner dtype is enum (pola-r…
af2aff3 
…s#13938)
@mcrumiller mcrumiller deleted the list-enum-merge branch February 26, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue using Concat on List of Enum Types
2 participants
@mcrumiller @ritchie46