fix: check input type for arr/list.contains
#13959
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all operations in
list/arr
namespace ensures the input type when unpack series. Butcontains
is an exception due to the reuse ofis_in
ops. As a result, you can even callarr.contains
on list series.IMO, we should raise for things like
ListSeries.arr.xxx
orArraySeries.list.xxx
. After all, they are not essentially the same type. In particular, you can't even convert a list to an array with unequal width.