fix: Raise for .dt.epoch and .dt.timestamp for Duration dtype #13962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
stinodego
changed the title
|
This can be merged as a bug fix, in my opinion. |
github-actions
bot
added
fix
ritchie46
approved these changes
Jan 28, 2024
|
sure thing, thanks! |
MarcoGorelli
requested review from
stinodego,
c-peters,
alexander-beedie and
orlp
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13208
this could be done with a deprecation cycle, but is it really worth it? this could just be a breaking 1.0 change imho