-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Return appropriate data type for time mean
and median
#14471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just some minor comments
@MarcoGorelli I believe I've resolved all of your issues with minor test improvements:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14471 +/- ##
==========================================
+ Coverage 81.14% 81.16% +0.01%
==========================================
Files 1363 1368 +5
Lines 175282 175417 +135
Branches 2527 2527
==========================================
+ Hits 142236 142379 +143
+ Misses 32568 32561 -7
+ Partials 478 477 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor typing comment, but I think this looks good
thanks for sticking with these!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mcrumiller !
Resolves #14470. Part of overall #13599.
This also moves one step closer to deprecating
Series.dt.mean
andSeries.dt.median
, as the base Series' mean and median now support time dtypes.Using the example from the issue, all cases now properly output a duration: