Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove needless inner type clone #16718

Merged
merged 1 commit into from
Jun 4, 2024
Merged

refactor: Remove needless inner type clone #16718

merged 1 commit into from
Jun 4, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.47%. Comparing base (520c268) to head (5a4f61f).

Files Patch % Lines
...tes/polars-ops/src/chunked_array/list/namespace.rs 41.66% 7 Missing ⚠️
crates/polars-expr/src/expressions/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16718      +/-   ##
==========================================
- Coverage   81.48%   81.47%   -0.01%     
==========================================
  Files        1415     1415              
  Lines      186724   186721       -3     
  Branches     3018     3018              
==========================================
- Hits       152146   152139       -7     
- Misses      34046    34050       +4     
  Partials      532      532              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jun 4, 2024

CodSpeed Performance Report

Merging #16718 will improve performances by 18.18%

Comparing borrowed (5a4f61f) with main (520c268)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main borrowed Change
test_groupby_h2oai_q1 2.6 ms 2.2 ms +18.18%

@ritchie46 ritchie46 merged commit 0751676 into main Jun 4, 2024
22 checks passed
@ritchie46 ritchie46 deleted the borrowed branch June 4, 2024 13:45
@c-peters c-peters added the accepted Ready for implementation label Jun 9, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants