Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update date_range to no longer produce datetime ranges #16734

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jun 4, 2024

Ref #13525

Skipping this in the breaking section of the changelog in favor of #16715

@github-actions github-actions bot added breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 4, 2024
@stinodego stinodego marked this pull request as ready for review June 4, 2024 23:09
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.44%. Comparing base (ddf8126) to head (09a562e).
Report is 9 commits behind head on main.

Files Patch % Lines
...ars-plan/src/dsl/function_expr/range/date_range.rs 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16734      +/-   ##
==========================================
- Coverage   81.45%   81.44%   -0.01%     
==========================================
  Files        1413     1413              
  Lines      186096   186053      -43     
  Branches     2776     2756      -20     
==========================================
- Hits       151588   151537      -51     
- Misses      33988    34013      +25     
+ Partials      520      503      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit 5d0e339 into main Jun 5, 2024
27 checks passed
@stinodego stinodego deleted the breaking-date-range branch June 5, 2024 17:35
@c-peters c-peters added the accepted Ready for implementation label Jun 9, 2024
@stinodego stinodego removed the breaking Change that breaks backwards compatibility label Jun 12, 2024
@github-actions github-actions bot added the breaking Change that breaks backwards compatibility label Jun 12, 2024
@stinodego stinodego removed the breaking Change that breaks backwards compatibility label Jun 12, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants