Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Raise on non-positive json schema inference #16770

Merged
merged 3 commits into from
Jun 7, 2024
Merged

fix: Raise on non-positive json schema inference #16770

merged 3 commits into from
Jun 7, 2024

Conversation

ritchie46
Copy link
Member

closes #16760

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jun 6, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 6, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #16770 will not alter performance

Comparing err (c461ae2) with err (8743d40)

Summary

✅ 37 untouched benchmarks

@ritchie46 ritchie46 merged commit a0a577a into main Jun 7, 2024
24 of 25 checks passed
@ritchie46 ritchie46 deleted the err branch June 7, 2024 14:12
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
@ritchie46 @Wouittone
fix: Raise on non-positive json schema inference (pola-rs#16770)
a6a9bc8
This was referenced Jul 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read_json panics when infer_schema_length = 0
1 participant
@ritchie46