Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: A different approach to warning users of fork() issues with Polars #19197

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

itamarst
Copy link
Contributor

@itamarst itamarst commented Oct 11, 2024

Just print a warning when fork() is used at the same time as Polars, which is what jax does. Users aren't as likely to see warnings, but it's something, and it's less intrusive hopefully than the previous attempt that got reverted.

@itamarst itamarst changed the title feature(python): A different approach to warning users of fork() issues with Polars feat: A different approach to warning users of fork() issues with Polars Oct 11, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Oct 11, 2024
@itamarst itamarst marked this pull request as ready for review October 12, 2024 12:27
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.97%. Comparing base (20ead46) to head (a65272f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/__init__.py 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19197      +/-   ##
==========================================
- Coverage   80.03%   79.97%   -0.06%     
==========================================
  Files        1528     1529       +1     
  Lines      209657   209822     +165     
  Branches     2416     2417       +1     
==========================================
+ Hits       167791   167809      +18     
- Misses      41317    41463     +146     
- Partials      549      550       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants