Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add missing deprecation notice to str.concat #19324

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LiamConnors
Copy link

#19144

Would it make sense to take out the deprecation notice further down as part of this? I guess it wouldn't change for str.concat now if it's been deprecated?

issue_deprecation_warning(
"The default `delimiter` for `str.concat` will change from '-' to an empty string."
" Pass a delimiter to silence this warning.",
version="0.20.5",
)

@LiamConnors LiamConnors changed the title docs: add missing deprecation notice to str.concat docs: Add missing deprecation notice to str.concat Oct 20, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Oct 20, 2024
@LiamConnors LiamConnors marked this pull request as ready for review October 20, 2024 03:45
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.22%. Comparing base (dbc8368) to head (1351550).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19324      +/-   ##
==========================================
- Coverage   80.24%   80.22%   -0.02%     
==========================================
  Files        1523     1523              
  Lines      209524   209525       +1     
  Branches     2434     2434              
==========================================
- Hits       168127   168093      -34     
- Misses      40842    40877      +35     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant