Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Don't pickle entire python function for object store keying #19340

Merged

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Oct 21, 2024

We use the memory address *const T of the Arc<T> instead.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.19%. Comparing base (08732c4) to head (f83f740).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/cloud/credential_provider.rs 80.00% 1 Missing ⚠️
crates/polars-io/src/cloud/object_store_setup.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19340      +/-   ##
==========================================
- Coverage   80.21%   80.19%   -0.03%     
==========================================
  Files        1523     1523              
  Lines      209544   209871     +327     
  Branches     2434     2434              
==========================================
+ Hits       168096   168303     +207     
- Misses      40893    41013     +120     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review October 21, 2024 07:31
@ritchie46
Copy link
Member

ritchie46 commented Oct 21, 2024

What do we cache here exactly? Maybe we can implement hash in combination with the pointers address. Python supports that as well.

@nameexhaustion
Copy link
Collaborator Author

What do we cache here exactly?

We are caching the object stores that we build, I believe in order to reduce DNS requests because every object store instance performs its own DNS requests - (maybe ref #11607).

Copy link

codspeed-hq bot commented Oct 22, 2024

CodSpeed Performance Report

Merging #19340 will improve performances by 28.96%

Comparing nameexhaustion:object-store-cred-provider-hash (f83f740) with main (eb596c9)

Summary

⚡ 1 improvements
✅ 40 untouched benchmarks

Benchmarks breakdown

Benchmark main nameexhaustion:object-store-cred-provider-hash Change
test_groupby_h2oai_q7 2.5 ms 2 ms +28.96%

@ritchie46 ritchie46 merged commit c655e8d into pola-rs:main Oct 23, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants