Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Fix unsoundness in group_tuples_perfect #19359

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 21, 2024

Supersedes #19357.

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 48 lines in your changes missing coverage. Please review.

Project coverage is 80.21%. Comparing base (27289b2) to head (276713a).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/frame/group_by/perfect.rs 27.27% 48 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19359      +/-   ##
==========================================
+ Coverage   80.18%   80.21%   +0.02%     
==========================================
  Files        1523     1523              
  Lines      209897   209853      -44     
  Branches     2434     2434              
==========================================
+ Hits       168314   168330      +16     
+ Misses      41028    40968      -60     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 11bd08e into pola-rs:main Oct 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants