Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Release GIL in gather_with_series() and friend #19383

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

itamarst
Copy link
Contributor

Fixes the reported part of #19358, but there may be other similar regressions as yet unreported.

Given that caveat, @ritchie46 also wanted to (temporarily) revert #19199 too since that's what made this regression start happening.

The full fix will be #19382, after which #19199 can be reapplied.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Oct 22, 2024
@itamarst itamarst marked this pull request as ready for review October 22, 2024 18:13
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.19%. Comparing base (1d210ab) to head (0421cc3).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/dataframe/general.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19383      +/-   ##
==========================================
- Coverage   80.21%   80.19%   -0.02%     
==========================================
  Files        1523     1527       +4     
  Lines      210096   210341     +245     
  Branches     2432     2430       -2     
==========================================
+ Hits       168526   168682     +156     
- Misses      41014    41105      +91     
+ Partials      556      554       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 8bf14d8 into pola-rs:main Oct 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants