feat(python): Support querying specific snapshot by id in scan_iceberg #19388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corleyma
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
corleyma
changed the title
github-actions
bot
added
enhancement
corleyma
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19388 +/- ##
==========================================
- Coverage 80.21% 80.20% -0.02%
==========================================
Files 1523 1527 +4
Lines 210096 210346 +250
Branches 2432 2432
==========================================
+ Hits 168526 168701 +175
- Misses 41014 41091 +77
+ Partials 556 554 -2 ☔ View full report in Codecov by Sentry. |
|
@alexander-beedie could you review this one? |
alexander-beedie
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Yup, definitely a useful addition; the integration looks good/clean to me.
@corleyma, thanks for this one - bonus points for providing good unit tests 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for querying historical table snapshots when using
scan_icebergby adding an optional "snapshot_id" argument that is propagated to the underlying pyiceberg DataScan.