fix: Fix ColumnNotFound when using pl.element() inside list.eval
#19438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
commented
Oct 24, 2024
| .lazy() | ||
| .without_optimizations() | ||
| .with_simplify_expr(true) | ||
| .select([expr.clone()]); | ||
| let schema = lf.collect_schema()?; |
There was a problem hiding this comment.
We accidentally passed the output schema instead of the input schema to create_physical_expr
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19438 +/- ##
===========================================
+ Coverage 60.05% 79.99% +19.94%
===========================================
Files 1533 1533
Lines 210940 210940
Branches 2442 2442
===========================================
+ Hits 126680 168748 +42068
+ Misses 83706 41638 -42068
Partials 554 554 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19317
Fixes #19345