fix: Ensure struct eq/ne_missing also compares outer validity
#19443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
changed the title
eq_missing also compares outer validityeq/ne_missing also compares outer validity
nameexhaustion
commented
Oct 25, 2024
| @@ -1255,6 +1255,9 @@ def test_parquet_list_element_field_name() -> None: | |||
| assert "child 0, element: int64" in schema_str | |||
|
|
|||
|
|
|||
| @pytest.mark.skip( | |||
| reason="TODO: fix Parquet writing Decimal-in-struct with precision > 18" | |||
There was a problem hiding this comment.
opened an issue for this at #19448 - this bug had always existed but we never caught it because assert_frame_equal used the incorrect eq_missing on structs
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19443 +/- ##
==========================================
- Coverage 79.96% 79.94% -0.03%
==========================================
Files 1534 1534
Lines 211037 211059 +22
Branches 2444 2444
==========================================
- Hits 168755 168721 -34
- Misses 41727 41783 +56
Partials 555 555 ☔ View full report in Codecov by Sentry. |
|
A rebase away. |
nameexhaustion
force-pushed
the
struct-eq-missing
branch
from
f19adf5
to
92638e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19156