Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Don't consume c_stream as iterable #20899

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

deanm0000
Copy link
Collaborator

fixes #20889

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.76%. Comparing base (7bf42dd) to head (10090dc).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20899   +/-   ##
=======================================
  Coverage   79.76%   79.76%           
=======================================
  Files        1569     1569           
  Lines      222895   222895           
  Branches     2573     2573           
=======================================
  Hits       177782   177782           
  Misses      44521    44521           
  Partials      592      592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ion-elgreco ion-elgreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for addressing it:)

@ritchie46 ritchie46 merged commit 2352c1e into pola-rs:main Jan 26, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't read from closed stream (arro3.core.RecordBatchReader)
3 participants