chore: remove old TODOs (#1254)

pola-rs · Oct 10, 2024 · 0122e29 · 0122e29
1 parent 61fb332
commit 0122e29
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 13 deletions.
diff --git a/R/after-wrappers.R b/R/after-wrappers.R
@@ -285,7 +285,7 @@ pl_class_names = sort(
     "RPolarsExpr", "RPolarsDataFrame", "RPolarsWhen", "RPolarsThen",
     "RPolarsChainedWhen", "RPolarsChainedThen", "RPolarsSQLContext"
   )
-) # TODO discover all public class automatically
+)
 
 pub_env = as.environment(asNamespace("polars"))
 pub_class_env = as.environment(mget(pl_class_names, envir = pub_env))

diff --git a/R/as_polars.R b/R/as_polars.R
@@ -198,7 +198,6 @@ as_polars_df.RPolarsLazyGroupBy = function(x, ...) {
 }
 
 
-# TODO: link to DataTypes documents
 #' @rdname as_polars_df
 #' @param rechunk A logical flag (default `TRUE`).
 #' Make sure that all data of each column is in contiguous memory.

diff --git a/R/error__trait.R b/R/error__trait.R
@@ -91,7 +91,6 @@ plain.default = function(err, msg) {
 }
 
 
-## TODO refactor upgrade_err into as.RPolarsErr
 #' Internal generic method to add plain text to error message
 #' @details
 #' polars converts any other error types to RPolarsErr.

diff --git a/R/expr__expr.R b/R/expr__expr.R
@@ -121,7 +121,6 @@ Expr_print = function() {
   paste0(ls(RPolarsExpr, pattern = pattern), completion_symbols$method)
 }
 
-# TODO: rewrite as something like `as_polars_expr()`
 #' wrap as literal
 #' @description use robj_to!(Expr) on rust side or rarely wrap_e on R-side
 #' This function is only kept for reference
@@ -135,9 +134,6 @@ wrap_e = function(e, str_to_lit = TRUE) {
   internal_wrap_e(e, str_to_lit) |> unwrap()
 }
 
-
-## TODO refactor to \(e, str_to_lit = TRUE, argname = NULL) wrap_e(e) |> result()
-
 #' wrap as Expression capture ok/err as result
 #' @param e an Expr(polars) or any R expression
 #' @param str_to_lit bool should string become a column name or not, then a literal string
@@ -364,7 +360,6 @@ Expr_pow = function(exponent) {
 #' !pl$lit(TRUE)
 Expr_not = use_extendr_wrapper
 
-# TODO: move to another file and create `S3_logic.Rd`
 #' @export
 `!.RPolarsExpr` = function(x) x$not()
 

diff --git a/R/functions__lazy.R b/R/functions__lazy.R
@@ -1,4 +1,3 @@
-# TODO: rewrite with generic function `as_polars_lit`
 #' Create a literal value
 #'
 #' @param x A vector of any length
@@ -56,8 +55,6 @@ pl_all = function(name = NULL) {
   }
 
   stop("not implemented")
-  # TODO implement input list of Expr as in:
-  # https://github.com/pola-rs/polars/blob/589f36432de6e95e81d9715a77d6fe78360512e5/py-polars/polars/internals/lazy_functions.py#L1095
 }
 
 

diff --git a/R/parse_as_duration.R b/R/parse_as_duration.R
@@ -27,7 +27,6 @@
 NULL
 
 
-# TODO: rewrite the Rust macro for R object into Polars duration
 # TODO: use this function inside of `Expr_rolling`, `LazyFrame_join_asof`, `DataFrame_join_asof`
 #' Parse an object as the Polars duration string language
 #'

diff --git a/R/series__series.R b/R/series__series.R
@@ -506,7 +506,6 @@ Series_compare = function(other, op) {
 }
 
 
-# TODO: move to the other file
 #' @export
 #' @rdname Series_compare
 #' @param s1 lhs Series