check length of statistics

pola-rs · Jul 1, 2024 · 403443b · 403443b
1 parent f74f3c3
commit 403443b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/R/utils.R b/R/utils.R
@@ -681,6 +681,9 @@ is_named = function(x) {
 
 # Used in parquet write/sink
 translate_statistics = function(statistics) {
+  if (length(statistics) != 1) {
+    return(Err_plain("`statistics` must be of length 1."))
+  }
   if (is.logical(statistics)) {
     if (isTRUE(statistics)) {
       statistics = list(

diff --git a/tests/testthat/test-parquet.R b/tests/testthat/test-parquet.R
@@ -115,4 +115,8 @@ test_that("write_parquet: argument 'statistics'", {
     dat$write_parquet(tmpf, statistics = "foo"),
     "`statistics` must be TRUE/FALSE, 'full', or a named list."
   )
+  expect_grepl_error(
+    dat$write_parquet(tmpf, statistics = c(max = TRUE, min = FALSE)),
+    "`statistics` must be of length 1."
+  )
 })
diff --git a/tests/testthat/test-sink_stream.R b/tests/testthat/test-sink_stream.R
@@ -38,6 +38,10 @@ test_that("sink_parquet: argument 'statistics'", {
     lf$sink_parquet(tmpf, statistics = "foo"),
     "`statistics` must be TRUE/FALSE, 'full', or a named list."
   )
+  expect_grepl_error(
+    lf$sink_parquet(tmpf, statistics = c(max = TRUE, min = FALSE)),
+    "`statistics` must be of length 1."
+  )
 })
 
 test_that("Test sinking data to IPC file", {