fix: the latest nanoarrow supports utf8view type

pola-rs · Oct 16, 2024 · c655549 · c655549
1 parent e3c1343
commit c655549
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -32,7 +32,7 @@ Suggests:
     jsonlite,
     knitr,
     lubridate,
-    nanoarrow (>= 0.4.0),
+    nanoarrow (>= 0.6.0),
     nycflights13,
     patrick,
     pillar,

diff --git a/tests/testthat/test-pkg-nanoarrow.R b/tests/testthat/test-pkg-nanoarrow.R
@@ -1,5 +1,5 @@
 test_that("as_nanoarrow_array_stream() works for DataFrame", {
-  skip_if_not_installed("nanoarrow")
+  skip_if_not_installed("nanoarrow", minimum_version = "0.6.0")
 
   df = pl$DataFrame(a = 1L, b = "two")
   stream = nanoarrow::as_nanoarrow_array_stream(df)
@@ -9,12 +9,10 @@ test_that("as_nanoarrow_array_stream() works for DataFrame", {
     data.frame(a = 1L, b = "two")
   )
 
-  # nanoarrow does not support the string view type yet
-  # https://github.com/apache/arrow-nanoarrow/pull/367
-  expect_grepl_error(
+  expect_identical(
     nanoarrow::as_nanoarrow_array_stream(df, compat_level = TRUE) |>
       as.data.frame(),
-    "Unknown format: 'vu'"
+    data.frame(a = 1L, b = "two")
   )
 })