Vignette to list some differences between R and Python API #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olars into vignette-diff-python
eitsupi
requested changes
Apr 10, 2024
eitsupi
reviewed
Apr 10, 2024
eitsupi
reviewed
Apr 11, 2024
Comment on lines
74
to
87
| ```r | ||
| > hms::hms(56, 34, 12) | ||
| 12:34:56 | ||
|
|
||
| > pl$DataFrame(x = hms::hms(56, 34, 12)) | ||
| shape: (1, 1) | ||
| ┌─────────┐ | ||
| │ x │ | ||
| │ --- │ | ||
| │ f64 │ | ||
| ╞═════════╡ | ||
| │ 45296.0 │ | ||
| └─────────┘ | ||
| ``` |
There was a problem hiding this comment.
Could this be in reprex style so that it can be copied and pasted and executed?
There was a problem hiding this comment.
I added the reprex style but those chunks are not evaluated every time (that would require us to put hms and geos in Suggests)
There was a problem hiding this comment.
Of course I don't think this needs to be an executable code block for now, but I think hms will need to be included in Suggests at some point. (#919)
eitsupi
reviewed
Apr 11, 2024
Comment on lines
93
to
105
| ```r | ||
| > geos::as_geos_geometry("LINESTRING (0 1, 3 9)") | ||
| <geos_geometry[1]> | ||
| [1] <LINESTRING (0 1, 3 9)> | ||
|
|
||
| > pl$DataFrame(x = geos::as_geos_geometry("LINESTRING (0 1, 3 9)")) | ||
| Error: Execution halted with the following contexts | ||
| 0: In R: in $DataFrame(): | ||
| 0: During function call [pl$DataFrame(x = geos::as_geos_geometry("LINESTRING (0 1, 3 9)"))] | ||
| 1: When constructing polars literal from Robj | ||
| 2: Encountered the following error in Rust-Polars: | ||
| expected Series | ||
| ``` |
There was a problem hiding this comment.
Ditto. (Maybe with tryCatch)
eitsupi
approved these changes
Apr 11, 2024
|
Maybe altdoc file(s) should be updated? r-polars/altdoc/mkdocs_static.yml Line 53 in de1fd05 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1012
We can add more things later if necessary.