Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: fix list type column conversion from data frame #1022

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Apr 11, 2024

A follow up for #1021

I was trying more complex nested type cases and learned that the columns of list class of data.frame are AsIs class and the list class is hidden.

data.frame(a = I(list(data.frame(b = 1L))))$a |> class()
#> [1] "AsIs"

Created on 2024-04-11 with reprex v2.1.0

So it was necessary to add a process here to convert this column back to the list class to convert it to the Series as intended.

Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, not sure if you want to merge this or #1023 first so I'll let you do that

@eitsupi eitsupi merged commit 5aa0b50 into main Apr 11, 2024
19 checks passed
@eitsupi eitsupi deleted the more-nested branch April 11, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants