-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: $str$parse_int()
-> $str$to_integer()
#1038
Conversation
.to_integer(robj_to!(PLExprCol, base)?, robj_to!(bool, strict)?) | ||
.with_fmt("str.parse_int") | ||
.to_integer(base, strict) | ||
.with_fmt("str.to_integer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed (especially since it's the python syntax)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be the case too, but I cannot be sure because there are a large number of the same items in other places.
Co-authored-by: Etienne Bacher <[email protected]>
No description provided.