Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move conversion to string-duration fully to R #1097

Merged
merged 5 commits into from
May 19, 2024

Conversation

etiennebacher
Copy link
Collaborator

@etiennebacher etiennebacher commented May 18, 2024

Currently, parsing duration is done like that:

  • pass the string from R to Rust
  • eval parse_as_polars_duration_string() from Rust using the R! macro
  • use this result in Rust

Since parse_as_polars_duration_string() is already defined in R, we could just call this on the string and then pass the result to Rust.

Also added a couple of small refactor and clippy suggestions.

@etiennebacher etiennebacher changed the title refactor: move string to duration conversion fully to R refactor: move conversion to string-duration fully to R May 18, 2024
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eitsupi eitsupi merged commit 1f8a46e into main May 19, 2024
33 of 35 checks passed
@eitsupi eitsupi deleted the refactor-parse-duration branch May 19, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants