Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename arguments of $unnest() #1174

Merged
merged 3 commits into from
Aug 8, 2024
Merged

feat: rename arguments of $unnest() #1174

merged 3 commits into from
Aug 8, 2024

Conversation

etiennebacher
Copy link
Collaborator

Close #1080

Also improve test coverage, and other docs changes due to roxygen2 update

@etiennebacher etiennebacher changed the title Rename inputs of $unnest() Rename arguments of $unnest() Aug 8, 2024
@etiennebacher etiennebacher changed the title Rename arguments of $unnest() feat: rename arguments of $unnest() Aug 8, 2024
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a breaking change, so can you mark it as a breaking change?

NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
@etiennebacher
Copy link
Collaborator Author

I don't think it is, the old behavior still works (and I added a test for this)

Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks!

@eitsupi eitsupi merged commit 724f208 into main Aug 8, 2024
33 of 35 checks passed
@eitsupi eitsupi deleted the unnest_revamp branch August 8, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<DataFrame>$unnest()'s arguments are different from Python Polars
2 participants