Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: version 0.19.1 #1213

Merged
merged 1 commit into from
Aug 30, 2024
Merged

release: version 0.19.1 #1213

merged 1 commit into from
Aug 30, 2024

Conversation

etiennebacher
Copy link
Collaborator

No description provided.

@etiennebacher etiennebacher merged commit bed21da into main Aug 30, 2024
17 of 19 checks passed
@etiennebacher etiennebacher deleted the v0.19.1rc branch August 30, 2024 18:25
@eitsupi
Copy link
Collaborator

eitsupi commented Aug 31, 2024

Perhaps you are tagging the wrong commit, as the commit tagged v0.19.1 is actually v0.19.0.

@etiennebacher
Copy link
Collaborator Author

etiennebacher commented Aug 31, 2024

Ah, do you know if I can change the tagged commit or do I need to delete the release and make a new one?

@eitsupi
Copy link
Collaborator

eitsupi commented Aug 31, 2024

We need to delete the release on the GitHub, and then delete the tag on GitHub afterwards.
Then push the tag again to create the release.

@eitsupi
Copy link
Collaborator

eitsupi commented Aug 31, 2024

@etiennebacher Perhaps you misunderstand the release process. Could you please check carefully how the tags have been tagged in the past and re-release them?
(Over the past few months, the version number of the main branch has never been anything other than .9000)

@eitsupi
Copy link
Collaborator

eitsupi commented Aug 31, 2024

I will remake the release as this is causing the CI in the downstream repository to break and needs an urgent fix.

@eitsupi eitsupi restored the v0.19.1rc branch August 31, 2024 09:35
@eitsupi eitsupi deleted the v0.19.1rc branch August 31, 2024 09:38
@etiennebacher
Copy link
Collaborator Author

Sorry about that, I may have misunderstood those steps in DEVELOPMENT.md:

  1. Create a local branch for the release, push it to the remote repository (main
    repository), then open a pull request to the main branch.
  2. Bump the R package version with the usethis package.
usethis::use_version()
# Please choose `major`, `minor` or `patch`
  1. Check the CI status of the pull request.
  2. Push a tag named starting with v (e.g. v0.10.0). It triggers the GitHub
    action to build the website and create a GitHub release.
  3. Bump the R package version to "dev version" with the usethis package
    before merging the pull request.

When I created the v0.19.1 tag in the Github interface, I forgot to change the target from "main" to the branch created in step 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants