-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix local build CMD #331
fix local build CMD #331
Conversation
The other option would be to do: cd ..
R CMD INSTALL --no-multiarch --with-keep.source r-polars |
@philipp-baumann thx alot for spotting this <3 Seem you're right on my local computer and as far as I can see :) Maybe we should start recommending the Makefile. |
ok cool, no prob. |
@sorhawell like the Make approach you suggested. |
Co-authored-by: eitsupi <[email protected]>
thank you @eitsupi |
README.md
Outdated
@@ -306,7 +306,7 @@ devtools::test() # run all unit tests | |||
**Step 4 (optional):** Build the package locally. | |||
|
|||
``` r |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update README.md too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update README.md too?
sure, sorry for forgetting.
@eitsupi just noticed the same
=> do you want a separate PR for this or shall I squash into this PR? |
@philipp-baumann Thanks for taking a look at that. I'm glad you made the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hi, thanks for making this great package! While testing local build, I noticed I had to adapt the command for the local build. Hence this mini PR. Cheers, Philipp