Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add robj clone #348

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Add robj clone #348

merged 6 commits into from
Aug 4, 2023

Conversation

sorhawell
Copy link
Collaborator

adds this internal function and use to check polars cloning behavior here 

#[extendr] //could be used to check copying/cloning behavior of R objects
pub fn clone_robj(robj: Robj) -> Robj {
    robj.clone()
}

@sorhawell
Copy link
Collaborator Author

@eitsupi @etiennebacher @Sicheng-Pan which version of rextendr do you prefer for polars, 0.3.1 or 0.3.1.9000?

@eitsupi
Copy link
Collaborator

eitsupi commented Aug 4, 2023

@eitsupi @etiennebacher @Sicheng-Pan which version of rextendr do you prefer for polars, 0.3.1 or 0.3.1.9000?

I believe it is the CRAN version that is installed via the Makefile.

@etiennebacher
Copy link
Collaborator

which version of rextendr do you prefer for polars, 0.3.1 or 0.3.1.9000?

I don't really know the difference between the two, but if the Makefile get the 0.3.1, let's stick to this one?

etiennebacher
etiennebacher reviewed Aug 4, 2023
View reviewed changes
R/extendr-wrappers.R
mem_address <- function(robj) .Call(wrap__mem_address, robj)

clone_robj <- function(robj) .Call(wrap__clone_robj, robj)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for them?

etiennebacher
etiennebacher approved these changes Aug 4, 2023
View reviewed changes
tests/testthat/test-extendr-meta.R Outdated Show resolved Hide resolved
@etiennebacher etiennebacher merged commit 8cee1b1 into main Aug 4, 2023
11 checks passed
@etiennebacher etiennebacher deleted the add_robj_clone branch August 4, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebacher etiennebacher etiennebacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sorhawell @eitsupi @etiennebacher