Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moderate ** claims in docs + rework title #353

Merged
merged 5 commits into from
Aug 8, 2023
Merged

Conversation

sorhawell
Copy link
Collaborator

@sorhawell sorhawell commented Aug 7, 2023

@etiennebacher TY for your persistence. I previously had issues rendering ** examples with ::reprex and in docs examples. I cannot reproduce that anymore. I likely have have done something as silly as using a dev load instead of fully building the package.

BTW it seems titles do not support quotes. Is it better to just avoid quotes in titles ?

image

@sorhawell sorhawell marked this pull request as draft August 7, 2023 12:58
R/expr__expr.R Outdated Show resolved Hide resolved
@etiennebacher
Copy link
Collaborator

Thanks, I think we can either drop the code formatting in title or in this case just remove the symbols (so the title would just be "Exponentiation")

@sorhawell sorhawell marked this pull request as ready for review August 8, 2023 13:20
@etiennebacher etiennebacher merged commit 35d6af0 into main Aug 8, 2023
10 checks passed
@etiennebacher etiennebacher deleted the revisit_pow_docs branch August 8, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants