Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor error handling set_options + misc docs #421

Merged
merged 10 commits into from
Oct 26, 2023
Merged

minor error handling set_options + misc docs #421

merged 10 commits into from
Oct 26, 2023

Conversation

sorhawell
Copy link
Collaborator

@sorhawell sorhawell commented Oct 9, 2023

this PR does

  • reduce Sys.sleep in some examples to reduce check time
  • require "All args must be explicitly and fully named." in pl$set_options() and raise specific errors if not. Otherwise behavior of pl$set_options() was silent do nothing.
  • update wording in some docs

@sorhawell sorhawell marked this pull request as ready for review October 23, 2023 20:28
@eitsupi eitsupi merged commit 17bea56 into main Oct 26, 2023
10 checks passed
@eitsupi eitsupi deleted the misc_minor branch October 26, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants