-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arguments to $profile()
#429
Conversation
…to profile-plot
…to profile-plot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is an interesting feature.
While there are other packages out there for creating great plots besides ggplot2
, it makes sense to go with ggplot2
here given that it is one of the most popular R package.
Some questions:
- Would it make sense to add an option feature that would allow the display of the plot to be the default?
- I think it might be useful if the ggplot object is the return value, is it possible to do that?
I don't really see the point here
We should return a list of 3 with the two tables + the plot when |
Sorry for the lack of clarity. I mean, I was imagining something like specifying it with the |
Nice! Could you also update the document? |
I added details on the returned value
I don't think this is necessary, this function shouldn't be called many times so that we need a global option for this |
Merge branch 'main' into profile-plot # Veuillez entrer un message de validation pour expliquer en quoi cette fusion est # nécessaire, surtout si cela fusionne une branche amont mise à jour dans une branche de sujet. # # Les lignes commençant par '#' seront ignorées, et un message vide # abandonne la validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :)
show_plot
TODO:
,figsize
truncate_nodes
We can't test this with snapshots because the timing changes at every run. I used
ggplot2
because doing the same graph with base R is just a pain, but if one of you wants to replace it with base R I don't have a problem with that.Example: