-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read_parquet err handling + examples #438
Conversation
@@ -73,9 +96,26 @@ pl$read_parquet = function( | |||
row_count_name = NULL, | |||
row_count_offset = 0L, | |||
low_memory = FALSE) { | |||
|
|||
#construct a derived call | |||
mc = match.call() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etiennebacher Interesting using quote + eval instead ...
, I have not thought of that. What would be the pros and cons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree scan_parquet needs a bigger overhaul. I would try to do that in separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This quote + eval() was already done in $read_csv()
, so I just took it there but I'm not the one who implemented it. I can't think of cons for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eitsupi what do you think pros and cons of using ... vs match/eval ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand the intent of your question, but I think match.call
is more convenient here since using ...
as a function argument has the disadvantage that auto-complete cannot be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sry my bad, I blame the fever :)
@@ -14,7 +14,23 @@ | |||
#' @name scan_parquet | |||
#' @rdname IO_scan_parquet | |||
#' @examples | |||
#' # TODO write parquet example | |||
#' #write example file | |||
#' my_parquet = tempfile(fileext = ".parquet") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it necessary to add processing to delete temporary files?
Also, is an extension necessary?
superseded by #492 |
No description provided.