Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused functions related to arrow #753

Merged
merged 1 commit into from
Jan 31, 2024
Merged

refactor: remove unused functions related to arrow #753

merged 1 commit into from
Jan 31, 2024

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Jan 31, 2024 •
edited
Loading

Part of #732

  • Remove unused internal R function rb_list_to_df
  • Move some codes from to_rust.rs to mod.rs for future use.
  • Remove some unused Rust functions and comments.

@eitsupi eitsupi changed the title refactor: remove unused funcs, comments, and move some code to the other file refactor: remove unused funcs related to arrow Jan 31, 2024
@eitsupi eitsupi changed the title refactor: remove unused funcs related to arrow refactor: remove unused functions related to arrow Jan 31, 2024
@eitsupi
Copy link
Collaborator Author

eitsupi commented Jan 31, 2024

Thanks for the review.

@eitsupi eitsupi merged commit a23e17d into main Jan 31, 2024
31 checks passed
@eitsupi eitsupi deleted the remove-unused-arrow-funcs branch January 31, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebacher etiennebacher etiennebacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eitsupi @etiennebacher