Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update super-linter configuration #159

Merged
merged 8 commits into from
Mar 22, 2024
Merged

Update super-linter configuration #159

merged 8 commits into from
Mar 22, 2024

Conversation

BinderDavid
Copy link
Collaborator

@BinderDavid BinderDavid commented Mar 20, 2024

  • Bump version of super-linter to v6
  • Configure the default branch correctly

Fixes #158

@BinderDavid BinderDavid force-pushed the fix-158 branch 2 times, most recently from 82d950e to 7f59011 Compare March 20, 2024 22:33
- Bump version of super-linter to v6.3.0
- Configure the default branch correctly
- Set less permissive permissions in CI
@BinderDavid
Copy link
Collaborator Author

@timsueberkrueb

Was the following line:

          VALIDATE_ALL_CODEBASE: false

due to excessive time taken in CI? If I understand it correctly then this option only runs the linter checks on changed files. But this can lead to situations where main is not always green, for example if the lints change when we bump super-linter to a new version. Should we try removing this line?

@timsueberkrueb timsueberkrueb merged commit 7c7ef2d into main Mar 22, 2024
6 checks passed
@BinderDavid BinderDavid deleted the fix-158 branch April 16, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter does not work correctly on PRs
2 participants