Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parser #181

Merged
merged 6 commits into from
Apr 17, 2024
Merged

Refactor parser #181

merged 6 commits into from
Apr 17, 2024

Conversation

BinderDavid
Copy link
Collaborator

  • Bump lalrpop to 0.20 which is up to 2x faster in compilation of grammars.
  • Make the lalrpop grammar more readable by factoring out individual expressions and toplevel declarations.
  • Make all the enum variants of cst::Exp into their own respective struct. This already simplifies the implementation of lowering, and enables even more simplifications once we can do the same thing for the ust/tst. (I don't want to do the same split there while we still have all the generic functions.)
  • ParamInst and TelescopeInst are not relevant for the CST, so I removed them there.

lang/parser/src/cst/decls.rs Outdated Show resolved Hide resolved
lang/parser/src/cst/decls.rs Outdated Show resolved Hide resolved
lang/parser/src/cst/decls.rs Outdated Show resolved Hide resolved
@BinderDavid BinderDavid merged commit f3d9b77 into main Apr 17, 2024
6 checks passed
@BinderDavid BinderDavid deleted the refactor-parser branch April 17, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants