Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Freevars computation and remove generic visitor #182

Merged
merged 6 commits into from
Apr 21, 2024

Conversation

BinderDavid
Copy link
Collaborator

@BinderDavid BinderDavid commented Apr 16, 2024

This is almost ready. I am still missing the correct logic for this place:

impl FV for ust::Case {
    fn visit_fv(&self, _v: &mut USTVisitor) {
        let ust::Case { info: _, name: _, args: _, body: _ } = self;

        //body.visit_fv(v);
        // TODO: The visitor context must be extended somehow.
    }
}

The tests are running through, but this is not a good sign. We don't have any tests which check xfunc at the moment.

@BinderDavid BinderDavid changed the title Rewrite Freevars computation and remove generic visitor WIP: Rewrite Freevars computation and remove generic visitor Apr 16, 2024
@timsueberkrueb timsueberkrueb changed the title WIP: Rewrite Freevars computation and remove generic visitor Rewrite Freevars computation and remove generic visitor Apr 21, 2024
@BinderDavid BinderDavid merged commit d007990 into main Apr 21, 2024
6 checks passed
@BinderDavid BinderDavid deleted the rewrite-freevars branch April 21, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants