Unify ShiftInRange and Shift traits #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinderDavid
force-pushed
the
simplify-shift
branch
from
12220f6 to
9222a04
Compare
BinderDavid
force-pushed
the
simplify-shift
branch
from
9222a04 to
cee74da
Compare
BinderDavid
force-pushed
the
simplify-shift
branch
from
7061065 to
54ae061
Compare
timsueberkrueb
approved these changes
Apr 17, 2024
BinderDavid
force-pushed
the
simplify-shift
branch
from
b39d21f to
8a35b80
Compare
|
Thx, I fixed the mistake in the doc comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR :) Basically I was a bit confused about how the
ShiftInRangeandShifttraits interact.It is still WIP because I want to write a bit more documentation about the expected invariant, which isn't documented at the moment.Edit: I added some unit tests and more comments explaining the range and how to implement shift correctly.