Refactor lowering #184
Merged
Refactor lowering #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lowering conceptually happens in two consecutive phases, but these were defined in the same module. This commit splits the logic into the two files lower.rs and downsweep.rs.
timsueberkrueb
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For lowering we have to traverse a module twice: Once to pick up all the items declared at the toplevel to generate a context for the second pass which traverses the module again using this information.
This split will become even more important for importing modules, so this PR just splits the
imp.rsfile which contained all the logic into three files:downsweep.rslower/exp.rsandlower/decls.rs.