-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate codespan dependency #425
Conversation
We probably can remove this: polarity/contrib/nix/package.nix Line 10 in e679bff
|
ccc01ca
to
b9c777c
Compare
bac3ccb
to
eb52c3b
Compare
bb4718e
to
6b2fb8c
Compare
Hello @Johann150 @Marwes @brendanzab @jyn514 @etaoins In the description #425 (comment) above we describe why we would like to inline some code from the If you agree to this, then please respond with a short comment "I do agree to license my contributions contained in this PR under the MIT license to the polarity project". Many thanks in advance :D (We used the git history to identify you as contributers which changed the code contained within this PR) |
I do agree to license my contributions contained in this PR under the MIT license to the polarity project |
3 similar comments
I do agree to license my contributions contained in this PR under the MIT license to the polarity project |
I do agree to license my contributions contained in this PR under the MIT license to the polarity project |
I do agree to license my contributions contained in this PR under the MIT license to the polarity project |
I agree to relicense my contributions too. There's not much difference between the licenses in practice anyway and I'm surprised it isn't dual-licensed in the first place. |
More my fault than anything 😔 |
6b2fb8c
to
0a85bc4
Compare
During parsing we annotate every syntax node with a
Span
which consists of two byte-indizes which measure the distance to the beginning of the document in bytes. We later need to convert these Spans to a new format which takes line-endings into account and uses positions with line and column numbers; this format is used by themiette
error reporting library and by the LSP protocol.So far we used the
codespan
library to perform these transformations, but due to the fact that we needed to change internal representations we used our own fork at www.github.com/polarity-lang/codespan. This is problematic because we cannot publishpolarity
on www.crates.io if we have dependencies which are not themselves on crates.io. This PR therefore inlines the few parts of the codespan library that we actually need in the codebase: the conversions of different position/span/range representations.This repository is currently dual-licensed using both the
Apache-2.0
and theMIT
license, whereas thecodespan
library is mono-licensed asApache-2.0
. We will therefore ask the contributors of the codespan library if they agree to also grant us aMIT
license for their respective contributions.