Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate IR from AST #431

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Generate IR from AST #431

merged 1 commit into from
Jan 4, 2025

Conversation

timsueberkrueb
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jan 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 182 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lang/backend/src/ast2ir/exprs.rs 0.00% 118 Missing ⚠️
lang/backend/src/ast2ir/decls.rs 0.00% 44 Missing ⚠️
lang/backend/src/ast2ir/traits.rs 0.00% 8 Missing ⚠️
lang/backend/src/ir/exprs.rs 0.00% 8 Missing ⚠️
lang/backend/src/ir/decls.rs 0.00% 4 Missing ⚠️
Files with missing lines Coverage Δ
lang/backend/src/ir/decls.rs 0.00% <0.00%> (ø)
lang/backend/src/ast2ir/traits.rs 0.00% <0.00%> (ø)
lang/backend/src/ir/exprs.rs 0.00% <0.00%> (ø)
lang/backend/src/ast2ir/decls.rs 0.00% <0.00%> (ø)
lang/backend/src/ast2ir/exprs.rs 0.00% <0.00%> (ø)

@timsueberkrueb timsueberkrueb force-pushed the ast2ir branch 3 times, most recently from f9dcd41 to 9296ead Compare January 4, 2025 22:43
BinderDavid
BinderDavid requested changes Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@BinderDavid BinderDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nitpicks.

lang/backend/src/ast2ir/traits.rs Show resolved Hide resolved
lang/backend/src/ast2ir/exprs.rs Show resolved Hide resolved
lang/backend/src/ast2ir/exprs.rs Show resolved Hide resolved
lang/backend/src/ast2ir/exprs.rs Show resolved Hide resolved
@timsueberkrueb timsueberkrueb merged commit f63e288 into main Jan 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinderDavid BinderDavid BinderDavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timsueberkrueb @BinderDavid