Releasing from 2.27.0-dev.17 to 2.27.0

.github/workflows/build.yaml

@@ -27,7 +27,7 @@ jobs:
       fail-fast: false
     steps:
       - name: git clone
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
       - name: Load Cached Flutter SDK
         uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
         with:
@@ -54,7 +54,7 @@ jobs:
           - test_dart2js
     steps:
       - name: git clone
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
       - name: Load Cached Flutter SDK
         uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
         with:
@@ -81,7 +81,7 @@ jobs:
 
     steps:
       - name: git clone
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
       - name: Load Cached Flutter SDK
         uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
         with:
@@ -101,20 +101,30 @@ jobs:
         with:
           name: golden_image_failures.${{ matrix.bot }}
           path: packages/devtools_app/test/**/failures/*.png
+      - name: Notify of Quick Fix
+        if: failure()
+        env:
+          WORKFLOW_ID: ${{ github.run_id }}
+        run: |
+          echo "::notice title=To Quickly Fix Goldens:: Run \`./tool/fix_goldens.sh $WORKFLOW_ID\` on your local branch."
 
   integration-test:
-    name: integration-test ${{ matrix.bot }}
+    name: integration-test ${{ matrix.bot }} - ${{ matrix.device }}
     needs: flutter-prep
     runs-on: macos-latest
     strategy:
       fail-fast: false
       matrix:
         bot:
           # Consider running integration tests in ddc mode, too.
-          - integration_dart2js
+          - dart2js
+        device:
+          - flutter
+          - flutter-web
+          - dart-cli
     steps:
       - name: git clone
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
       - name: Load Cached Flutter SDK
         uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
         with:
@@ -124,6 +134,7 @@ jobs:
       - name: tool/bots.sh
         env:
           BOT: ${{ matrix.bot }}
+          DEVICE: ${{ matrix.device }}
         run: ./tool/bots.sh
 
       - name: Upload Golden Failure Artifacts
@@ -144,7 +155,7 @@ jobs:
 #          - test_dart2js
 #    steps:
 #      - name: git clone
-#        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
+#        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
 #
 #      - name: tool/bots.sh
 #        env:
@@ -164,7 +175,7 @@ jobs:
 #          - integration_dart2js
 #    steps:
 #      - name: git clone
-#        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
+#        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
 #      - name: tool/bots.sh
 #        env:
 #          BOT: ${{ matrix.bot }}

.github/workflows/daily-dev-bump.yaml

@@ -17,8 +17,6 @@ on:
         required: false
         type: boolean
         default: false
-  pull_request:
-    types: [closed]
   schedule:
     # * is a special character in YAML so you have to quote this string
     - cron: "0 8 * * *" # Run every day at midnight Pacific Time
@@ -31,12 +29,12 @@ env:
 
 jobs:
   bump-version:
-    if: ${{ github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' }}
+    if: ${{ github.repository == 'flutter/devtools' }}
     name: Bump Version
     runs-on: ubuntu-latest
     steps:
       - name: git clone devtools
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
         with:
           ref: master
 
@@ -45,8 +43,6 @@ jobs:
       - name: setup git config
         run: |
 
-          # TODO(https://github.com/flutter/devtools/issues/4949):  Change the author to
-          # a flutter owned account
           git config user.name "DevTools Workflow Bot"
           git config user.email "[email protected]"
 
@@ -77,6 +73,15 @@ jobs:
             dart tool/update_version.dart auto --type major
             dart tool/update_version.dart auto --type dev
           elif [ "$UPDATE_TYPE" == "dev" ]; then
+            if ! echo "$ORIGINAL_VERSION" | grep -Eq "\-dev\.[0-9]+" ; then
+              ERROR_DESCRIPTION="Doing \
+            a Dev bump on a release version ($ORIGINAL_VERSION) is not supported. \
+            Ensure that that current version has been properly bumped to a '-dev.*' \
+            pre-release version, in order to continue daily dev bumps."
+
+              echo "::error ,title=Cannot do a dev bump on a Release Version ($ORIGINAL_VERSION)::$ERROR_DESCRIPTION" 
+              exit 1;
+            fi
             dart tool/update_version.dart auto --type dev
           else
             echo "ERROR: UNEXPECTED UPDATE TYPE: $UPDATE_TYPE"
@@ -114,22 +119,4 @@ jobs:
           GH_TOKEN: ${{ secrets.DEVTOOLS_WORKFLOW_BOT_TOKEN }}
           ORIGINAL_GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           IS_DRAFT: ${{ inputs.draft == true }}
-  clean-up-branches:
-    # If a pr is closed on a workflow bot PR, then clean up workflow bot branches.
-    if: ${{ github.event_name == 'pull_request' && github.event.action == 'closed'  && github.event.pull_request.user.login == 'DartDevtoolWorkflowBot'}}
-    name: Clean up Dev Bump Branches
-    runs-on: ubuntu-latest
-    steps:
-      - name: Clean up branches
-        run: |
-          # Get 5 most recent branches of closed DartDevtoolWorkflowBot PRs.
-          CLOSED_BRANCH_NAMES=$(gh pr list -A DartDevtoolWorkflowBot -s closed -L 5 --search sort:created-desc | grep auto-bump- | sed 's|.*\(auto-bump-[[:digit:]]*\).*|\1|')
-
-          # Get list of refs(branches) that exist on the remote
-          EXISTING_REFS=$(git ls-remote --heads | grep refs/heads/auto-bump-) 
-          for CLOSED_BRANCH in $CLOSED_BRANCH_NAMES; do
-            if echo "$EXISTING_REFS" | grep -q "$CLOSED_BRANCH" ; then
-              # If the branch still exists then we will delete it
-              gh api  /repos/flutter/devtools/git/refs/heads/$CLOSED_BRANCH -X DELETE
-            fi
-          done
+

.github/workflows/dcm.yaml

@@ -15,10 +15,9 @@ name: Dart Code Metrics
 
 on:
   pull_request_target:
-    # synchronize, opened, and reopened are the default pull_request_target
-    # types. labeled and unlabeled are also required to re-run workflow when
-    # the run-dcm-workflow label is added or removed.
-    types: [opened, reopened, labeled, unlabeled]
+    # labeled and unlabeled are required along with open to re-run
+    # workflow when the run-dcm-workflow label is added or removed.
+    types: [opened, labeled, unlabeled]
     branches:
       - master
     paths:
@@ -40,7 +39,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Clone Flutter DevTools
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
         with:
           ref: "${{ github.event.pull_request.head.sha }}"
       - name: Load Cached Flutter SDK

.github/workflows/flutter-candidate-update.yaml

@@ -0,0 +1,69 @@
+name: Flutter Candidate Update
+on:
+  workflow_dispatch: # Allows for manual triggering if needed
+  schedule:
+    # * is a special character in YAML so you have to quote this string
+    - cron: "0 8 * * *" # Run every day at midnight Pacific Time
+
+permissions:
+  contents: write
+  pull-requests: write
+
+env:
+  GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+jobs:
+  update-candidate:
+    if: ${{ github.repository == 'flutter/devtools' }}
+    name: Update Flutter Candidate Version
+    runs-on: ubuntu-latest
+    steps:
+      - name: git clone devtools
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
+        with:
+          ref: master
+
+      - uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
+
+      - name: setup git config
+        run: |
+
+          git config user.name "DevTools Workflow Bot"
+          git config user.email "[email protected]"
+
+      - name: get the latest flutter candidate
+        run: |
+          set -ex
+          pushd tool/
+          dart pub get
+          popd
+
+          tool/latest_flutter_candidate.sh | sed 's|refs/tags/||' > flutter-candidate.txt
+
+      - name: Create the PR
+        run: |
+          set -ex
+          if ! [[ `git status --porcelain --untracked-files=no` ]]; then
+            # No changes made, so we can just exit.
+            echo "No change to the flutter-candidate.txt file"
+            exit
+          fi
+          COMMIT_MESSAGE="Changing Flutter Candidate to $(cat flutter-candidate.txt)"
+          BRANCH_NAME="auto-candidate-$(date +%s)"
+          # Stage the file, commit and push
+          git checkout -b "$BRANCH_NAME"
+          git add .
+          git commit -m "$COMMIT_MESSAGE"
+          git push -u origin "$BRANCH_NAME"
+
+
+          PR_URL=$(gh pr create --title "$COMMIT_MESSAGE" --body "Automated Flutter candidate version bump.") 
+
+          # Change github credentials back to the actions bot.
+          GH_TOKEN="$ORIGINAL_GH_TOKEN"
+
+          gh pr edit $PR_URL --add-label "autosubmit"
+
+        env:
+          GH_TOKEN: ${{ secrets.DEVTOOLS_WORKFLOW_BOT_TOKEN }}
+          ORIGINAL_GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/flutter-prep.yaml

@@ -42,14 +42,14 @@ jobs:
       - name: Checkout PR branch for DevTools
         if: ${{ inputs.needs-checkout-merge == true }}
         id: checkout-pr-branch
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
         with:
           ref: "${{ github.event.pull_request.head.sha }}"
 
       # Otherwise use the default checkout action.
       - name: Checkout DevTools (default)
         if: steps.checkout-pr-branch.outcome == 'skipped'
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
 
       - name: Get Latest Flutter Candidate
         id: flutter-candidate

.github/workflows/scorecards-analysis.yml

@@ -23,12 +23,12 @@ jobs:
 
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744
         with:
           persist-credentials: false
 
       - name: "Run analysis"
-        uses: ossf/scorecard-action@80e868c13c90f172d68d1f4501dee99e2479f7af
+        uses: ossf/scorecard-action@08b4669551908b1024bb425080c797723083c031
         with:
           results_file: results.sarif
           results_format: sarif

.github/workflows/workflow-bot-cleanup.yaml

@@ -0,0 +1,53 @@
+name: Workflow Bot Cleanup
+on:
+  workflow_dispatch: # Allows for manual triggering if needed
+  schedule:
+    # * is a special character in YAML so you have to quote this string
+    - cron: "0 9 * * *" # Run every day
+permissions:
+  contents: write
+  pull-requests: write
+
+
+jobs:
+  clean-up-branches:
+    if: ${{ github.repository == 'flutter/devtools' }}
+    name: Clean up closed DartDevtoolWorkflowBot Branches
+    runs-on: ubuntu-latest
+    steps:
+      - name: Sparse checkout of the repository
+        uses: actions/checkout@v3
+        with:
+          sparse-checkout: |
+            README.md
+      - name: Clean up closed DartDevtoolWorkflowBot branches
+        run: |
+          set -e
+
+          # Get list of branches that exist on the remote, then filter for the workflow bot branches
+          EXISTING_BRANCHES=$(git ls-remote --heads | grep refs/heads | awk  '{print $2}' |sed 's|refs/heads/\(.*\)$|\1|')
+          for EXISTING_BRANCH in $EXISTING_BRANCHES; do
+            set +e # Turn off exit on error, since "gh pr view" may fail if branch doesn't exist
+            PR_INFO=$(gh pr view --json closed,author "$EXISTING_BRANCH")
+            if [[ $? -ne 0 ]]; then
+              # If getting PR_INFO fails assume the PR does not exist
+              echo "SKIP: No PR exists for $EXISTING_BRANCH"
+              continue
+            fi
+            set -e # Turn exit on error back on
+
+            PR_IS_CLOSED=$(echo $PR_INFO | jq -r '.closed')
+            PR_AUTHOR=$(echo $PR_INFO | jq -r '.author.login')
+            if [[ "$PR_IS_CLOSED" == "true" ]] && [[ "$PR_AUTHOR" == "DartDevtoolWorkflowBot" ]]; then
+              # Delete branches where:
+              # - DartDevtoolWorkflowBot is the author 
+              # - the PR is closed
+              echo "Deleting $EXISTING_BRANCH"
+              gh api /repos/flutter/devtools/git/refs/heads/$EXISTING_BRANCH -X DELETE
+            else
+              echo "SKIP: Avoiding $EXISTING_BRANCH { is_closed:$PR_IS_CLOSED, author:$PR_AUTHOR }"
+            fi
+          done
+
+        env:
+          GH_TOKEN: ${{ secrets.DEVTOOLS_WORKFLOW_BOT_TOKEN }}

.gitignore

@@ -29,6 +29,7 @@ packages/devtools_test/lib/src/mocks/generated.mocks.dart
 **/test/**/failures/
 *.dill
 DEPENDENCIES.md
+**/*.log
 
 # Ignore logs generated by VS Code
 **/logs/**

CONTRIBUTING.md

@@ -114,6 +114,8 @@ from the main devtools/ directory run:
 export LOCAL_DART_SDK=/path/to/dart-sdk
 dart ./tool/build_e2e.dart
 ```
+* Note: the LOCAL_DART_SDK needs to point to a local checkout of [dart-sdk](https://github.com/dart-lang/sdk/tree/main)
+* Note: if you are also developing server side code, e.g. the devtools_shared package, add a devtools_shared path override to `<path-to-dart-sdk>/pkg/dds/pubspec.yaml`.
 
 That will:
 - start the devtools server

flutter-candidate.txt

@@ -0,0 +1 @@
+3.14.0-11.0.pre