Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meson option to use gettext for translations in .policy files #486

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

bluca
Copy link
Member

@bluca bluca commented Aug 8, 2024

Disabled by default. Will be used in Debian/Ubuntu and derivatives,
where this patch has been carried out-of-tree for ~15 years.

Fixes #35

@zerocool438
Copy link

Operating system fedora 40.
After this patch is installed, the policy prompt is correct for the first time every time the polkit service is restarted. After that, only English is displayed.

@zerocool438
Copy link

@robert-ancell @bluca

@zerocool438
Copy link

systemd : 255.10-3.fc40
polkit: 124-2.fc40

@zerocool438
Copy link

1、sudo systemctl restart polkit.service
2、timedatectl set-timezone Asia/Singapore
微信图片_20240823111301

After that, Execute "timedatectl set-timezone Asia/Singapore" again.
微信图片_20240823111310

@bluca
Copy link
Member Author

bluca commented Aug 23, 2024

@zerocool438 thanks for testing - could you please try again with this new version just pushed?

@zerocool438
Copy link

@zerocool438 thanks for testing - could you please try again with this new version just pushed?
I'll give it a try.

@zerocool438
Copy link

@zerocool438 thanks for testing - could you please try again with this new version just pushed?
I noticed that you added judgment to the result value. I can just tell you the result value in these two executions.
source code:
截图 2024-08-26 15-28-27
journal:
截图 2024-08-26 15-25-21

@bluca

@bluca
Copy link
Member Author

bluca commented Aug 26, 2024

Is the problem with the GUI pop-up that you showed previously solved with the latest code changes in this PR?

@zerocool438
Copy link

Is the problem with the GUI pop-up that you showed previously solved with the latest code changes in this PR?

No, this PR didn't fix it.

@zerocool438
Copy link

Is the problem with the GUI pop-up that you showed previously solved with the latest code changes in this PR?

The phenomenon remains the same.

Disabled by default. Will be used in Debian/Ubuntu and derivatives,
where this patch has been carried out-of-tree for ~15 years.

Fixes polkit-org#35
@bluca
Copy link
Member Author

bluca commented Aug 27, 2024

Ok thanks, I've switched this to a disabled-by-default meson option. We can enable this in Debian and derivatives, and it can be kept disabled in Fedora and derivatives.

@bluca bluca changed the title Use gettext for translations in .policy files Add meson option to use gettext for translations in .policy files Aug 29, 2024
@bluca
Copy link
Member Author

bluca commented Oct 10, 2024

@jrybar-rh gentle ping - this is disabled by default so shouldn't affect Fedora, but it would allow us in Debian/Ubuntu to drop a downstream patch that we have been carrying for more than 10 years. Thanks!

@jrybar-rh jrybar-rh merged commit 8855372 into polkit-org:main Oct 11, 2024
33 checks passed
@bluca bluca deleted the gettext branch October 11, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[patch] Use gettext for translating user messages
4 participants