-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'Union' with use of more precise proof #110
Conversation
Before going too far on this, I'd want to look at the perf. I have a sneaking suspicion that this thing will allocate much harder than |
Okay, no problem - should I close it for now? |
Your call! I'm curious what tangible benefits this buys us --- does it allow us to do anything we couldn't otherwise, or is it merely aesthetic? |
Actually, #107 comes to my mind - |
I'm going to close this for now --- feel free to reopen if you feel we should reconsider. |
Stuff like #281 has made more more and more attracted to a solution like this. It'd make the machinery behind those kinds of stuff prettier. You've commented about performance, but shouldn't |
That's a reasonable argument. Anyone want to tackle this? |
I already have a solution in the works, so I'm up for it, but @TheMatten is probably also interested. Edit: Actually, it's very similar to what this pull request does, except it also addresses custom error messages. |
@KingoftheHomeless I currently don't have time to finish this - go for it if you want 🙂 |
Use of more precise:
instead of
Nat
+SNat
allows us to prove important properties and makes implementation a little bit simpler, e.g.:can now be proved with
EmptyCase
:TODO: