Small revisions and fixes For Wasm templates #1924
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d deploy manifests from templates
krisbitney
requested review from
dOrgJelli,
namesty and
pileks
as code owners
krisbitney
changed the title
dOrgJelli
requested changes
Oct 31, 2023
|
I'm good with merging this, but the CI is still red for the templates, looks like some of them aren't properly building: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Wasm templates in the following ways:
polywrap.test.yaml, cue file, and yarn scripts)polywrap.deploy.yamlfilesThe TS template doesn't build due to #1923
The Go template doesn't build due to #1925
For reasoning on why we would remove workflows: https://discord.com/channels/796821176743362611/1166324052164628560
I removed the deploy manifests because the default behavior of
npx polywrap deployis IPFS deployment. Since we are encouraging use of IPFS and Wrapscan URIs, most users will not need to customize deployment. Our documentation will provide ample guidance for users who do wish to use a deploy manifest.