Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CodeSurfer compatible with mdx-deck 2.x #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vlsi
Copy link

@vlsi vlsi commented Mar 24, 2019

Note: this is my first yarn/React experience, so the change might be off the track.
However the support for mdx-deck 2.x seems to be not that difficult.

fixes #53

@vlsi
Copy link
Author

vlsi commented Mar 24, 2019

PS I have no idea why react-docs fails to build:

$ yarn build
yarn run v1.12.3
$ docz build
{ parser: "babylon" } is deprecated; we now treat it as { parser: "babel" }.
▶  start     Creating an optimized production build...
✖  fatal     Failed to compile.

./.docz/app/root.jsx
Module not found: Can't resolve 'null' in '..../code-surfer/fixtures/react-docs/.docz/app'

@vlsi
Copy link
Author

vlsi commented Mar 25, 2019

website failure seems to be the same as jxnblk/mdx-deck#284 (gatsby still depends on mdx v1 which does not play well with mdx-deck 2)

@AndersDJohnson
Copy link

For what it's worth, this worked for me. @pomber any plans to merge and publish support for this?

@vlsi
Copy link
Author

vlsi commented May 5, 2019

Just in case: beware that mdx-deck has lots of pitfalls for delivering slides on stage.
It looks good when you start, however, there are small bits that appear out of thin air (e.g. lack of 16x9, lack of positioning, wrong "next slide" in speaker view, etc, etc), and it is especially painful in case you prepare the slides "a week before the event".

@@ -1,5 +1,5 @@
import React from "react";
import { Notes } from "mdx-deck";
import { Notes } from "@mdx-deck/components";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mdx-deck package actually exports all of the components in @mdx-deck/components. See here.

@pomber pomber mentioned this pull request May 13, 2019
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems to be incompatible with mdx-deck 2.0
3 participants